dont require precommit for proper formatting (valhalla#3961)

.pre-commit-config.yaml

@@ -1,33 +1,9 @@
 repos:
-  # C++
+  # liniting c++ and python
   - repo: local
     hooks:
     - id: format
       name: format
       entry: bash ./scripts/format.sh
       language: system
       pass_filenames: false
-
-  # Python formatter
-  - repo: https://github.com/psf/black
-    rev: 22.10.0
-    hooks:
-      - id: black
-        language_version: python3
-        args: ['--line-length=105', '--skip-string-normalization']
-        files: ^(src/bindings/python/|scripts/)
-
-  # Python linter
-  - repo: https://github.com/pycqa/flake8
-    rev: 5.0.4
-    hooks:
-      - id: flake8
-        # E501: ignore line length (black auto-formats)
-        # E731: ignore replace-lambda-with-def warnings
-        # E203: ignore "whitespace before ':'"
-        args: [
-          '--max-line-length=105',
-          '--extend-ignore=E501,E731,E203',
-          '--extend-exclude=src/bindings/python/__init__.py'
-        ]
-        files: ^(src/bindings/python/|scripts/)

scripts/bash_utils.sh

@@ -28,18 +28,15 @@ function setup_mason {
 
 }
 
-function setup_pre_commit {
+function setup_python {
   local python_bin=""
   if [[ $(command -v python3) != "" ]]; then
     python_bin="python3"
   elif [[ $(command -v python) != "" ]]; then
     python_bin="python"
   else
-    echo "WARNING: install python3 to set up pre-commit hooks."
+    echo "WARNING: install python3 for linting" 1>&2
     return
   fi
-  echo "INFO: Installing pre-commit"
-  ${python_bin} -m pip install --user --upgrade pre-commit
-  echo "INFO: Setting up pre-commit hooks"
-  ${python_bin} -m pre_commit install
+  echo ${python_bin}
 }

scripts/format.sh

@@ -12,7 +12,6 @@ readonly CLANG_FORMAT_VERSION=11.0.0
 
 source scripts/bash_utils.sh
 setup_mason
-setup_pre_commit
 
 ./mason/mason install clang-format $CLANG_FORMAT_VERSION
 ./mason/mason link clang-format $CLANG_FORMAT_VERSION
@@ -22,3 +21,15 @@ echo "Using clang-format $CLANG_FORMAT_VERSION from ${CLANG_FORMAT}"
 
 find src valhalla test bench -type f -name '*.h' -o -name '*.cc' \
   | xargs -I{} -P ${NPROC} ${CLANG_FORMAT} -i -style=file {}
+
+
+# Python setup
+py=$(setup_python)
+${py} -m pip install black==22.10.0 flake8==5.0.4
+python_sources=$(LANG=C find scripts src/bindings/python -type f -exec file {} \; | grep -F "Python script" | sed 's/:.*//')
+
+# Python formatter
+${py} -m black --line-length=105 --skip-string-normalization ${python_sources}
+
+# Python linter
+${py} -m flake8 --max-line-length=105 --extend-ignore=E501,E731,E203 --extend-exclude=src/bindings/python/__init__.py ${python_sources}