Skip to content

Commit

Permalink
Remove boost/date_time from baldr and odin (valhalla#1494)
Browse files Browse the repository at this point in the history
* added tz.cc

* trying to use date:tz db.

* required files for HowardHinnant/date

* updated to use date tz db.

* moved to new file.  init testing of HowardHinnant date lib

* reverted to master so that we can build.

* added tmp pivot date for datetime2.

* added datetime2

* added datetime2.

* updated namespace

* updted pivot.

* Added process to add iana Time Zone Database files headers

* more porting.

* added tests back.

* more porting.

* more porting.

* enabled more tests.

* Updated to laod on the north american timezone
Also, applied formatting changes

* Fixed the europe timezone diff test

* Process the reamining tz files

* Process date_time/windowsZones.xml to date_time_windows_zones.h

* Added windows logic for init_tzdb

* re-enabled all tests.

* clean up and finished is_restricted.

* fomatting.

* Added HowardHinnant/date as a thrid party

* Added date to third party include

* Added date to third party include

* move zonespec.csv to mjolnir

* moved transit dt logic to servicedays.

* moved to datetime.

* now using logic from servicedays.  todo: will have to port to use datetime.

* rm'd datetime2.

* bool for departat or arriveby no longer needed.

* removed datetime2.

* missing include

* moved from datetime2 to datetime.

* don't have posix info yet. this is a todo

* new pivot date will work for service days or datetime.

* rm'd datetime2.

* updated to use supported db that contains data from https://www.iana.org/time-zones

* used sv_pivot_date

* moved Boost::date_time from baldr to mojlnir

* updates for service days tests

* we expect midnight for the new pivot date.

* time added in datetime.  not needed here.

* rm'd datetime.

* should of been timeparsing.h and not servicedays.h.

* use simple string because the pivot date is now xxxx-xx-xx

* Remove boost/date_time from odin

* Some final boost clean up - thanks for pairing @kevinkreiser

* Updated CHANGELOG.md
  • Loading branch information
dgearhart authored Aug 30, 2018
1 parent 7b1e235 commit c106e6a
Show file tree
Hide file tree
Showing 47 changed files with 17,985 additions and 934 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@
[submodule "third_party/dirent"]
path = third_party/dirent
url = https://github.com/tronkko/dirent
[submodule "third_party/date"]
path = third_party/date
url = https://github.com/HowardHinnant/date.git
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## Release Date: UNRELEASED Valhalla 3.0
* **Enhancement**
* UPDATED: Refactor to use the pbf options instead of the ptree config [#1428](https://github.com/valhalla/valhalla/pull/1428) This completes [1357](https://github.com/valhalla/valhalla/issues/1357)
* UPDATED: Removed the boost/date_time dependency from baldr and odin. We added the Howard Hinnant date and time library as a submodule. [#1494](https://github.com/valhalla/valhalla/pull/1494)
* **Request Parsing**
* FIXED: Fixed through locations weren't honored [#1449](https://github.com/valhalla/valhalla/pull/1449)

Expand Down
8 changes: 4 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ add_subdirectory(src)

## Executable targets
if(ENABLE_TOOLS OR ENABLE_DATA_TOOLS OR ENABLE_SERVICES)
find_package(Boost 1.51 REQUIRED COMPONENTS program_options)
find_package(Boost 1.51 REQUIRED COMPONENTS program_options filesystem system)
find_package(Threads REQUIRED)
endif()

Expand Down Expand Up @@ -120,11 +120,11 @@ set(valhalla_data_tools valhalla_build_statistics valhalla_ways_to_edges valhall
## Valhalla services
set(valhalla_services valhalla_service valhalla_loki_worker valhalla_odin_worker valhalla_thor_worker)

if(ENABLE_DATA_TOOLS)
if(ENABLE_TOOLS)
foreach(program ${valhalla_programs})
get_source_path(path ${program})
add_executable(${program} ${path})
target_link_libraries(${program} Boost::program_options valhalla Threads::Threads)
target_link_libraries(${program} Boost::program_options valhalla Threads::Threads Boost::filesystem Boost::system)
install(TARGETS ${program} DESTINATION "${CMAKE_INSTALL_BINDIR}" COMPONENT runtime)
endforeach()
endif()
Expand All @@ -133,7 +133,7 @@ if(ENABLE_DATA_TOOLS)
foreach(program ${valhalla_data_tools})
get_source_path(path ${program})
add_executable(${program} ${path})
target_link_libraries(${program} valhalla Boost::program_options Threads::Threads)
target_link_libraries(${program} valhalla Boost::program_options Threads::Threads Boost::filesystem Boost::system)
install(TARGETS ${program} DESTINATION "${CMAKE_INSTALL_BINDIR}" COMPONENT runtime)
endforeach()

Expand Down
Loading

0 comments on commit c106e6a

Please sign in to comment.