Fixes #36686 - temporarily patch out Pulp dist hidden field #10701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36686 |
|
I am seeing this on an ansible collection repo sync on capsule: |
|
Rubocop failures..We could turn off rubocop for this file. |
ianballou
force-pushed
the
36686-pulpcore-3.28-n-1-fix
branch
2 times, most recently
from
67ef2a2
to
cb8aa41
Compare
|
@sjha4 this is all good now. |
|
More VCR failures suddenly... was there another update to the Pulp API bindings I wonder? |
|
We could pin the gems to the versions in koji. |
That's alright, we should be able to take in whatever the latest z version is. However, there really shouldn't be major API changes. I'll see if I find any suspicious changes. |
ianballou
force-pushed
the
36686-pulpcore-3.28-n-1-fix
branch
from
cb8aa41
to
d2c33fd
Compare
ianballou
force-pushed
the
36686-pulpcore-3.28-n-1-fix
branch
from
d2c33fd
to
99a55f9
Compare
sjha4
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Removes the hidden field from Pulpcore 3.28 supported clients so that n-1 smart proxy syncing works.
Considerations taken when implementing this change?
This should be removed as soon as possible.
What are the testing steps for this pull request?
Try syncing an n-1 smart proxy (that has Pulpcore 3.22) with varying repository types.