Fixes #36720 - Composable Expandable Table for Smart Proxy content #10716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
force-pushed
the
expandable_table_capsule
branch
from
2fa8027
to
a8ddab4
Compare
sjha4
force-pushed
the
expandable_table_capsule
branch
from
a8ddab4
to
e82eb5c
Compare
sjha4
force-pushed
the
expandable_table_capsule
branch
from
e82eb5c
to
60f6bea
Compare
sjha4
changed the title
(cherry picked from commit c5dc9dd)
sjha4
force-pushed
the
expandable_table_capsule
branch
from
60f6bea
to
434a00b
Compare
|
I think this is the one where I was complaining about the expansion carat, right? I addressed something similar in https://github.com/Katello/katello/pull/10697/files |
|
Seeing your comment now..Will address this in a PR I am working on..Closing this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Refactor the smart proxy content table as expandable table to prep for more changes on the page in follow-up PRs.
Considerations taken when implementing this change?
What are the testing steps for this pull request?