Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36988 - CV version should display Container manifest list count #10883

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fixes #36988 - CV version should display Container manifest list count #10883

merged 1 commit into from
Feb 14, 2024

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Feb 7, 2024

What are the changes introduced in this pull request?

Add container mainfest list views to CV versions and details and CV version comparison

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Create a couple container repos
  2. Create a CV with the repo and publish a couple versions.
  3. Make sure you can see container manifest list count in the versions list table under Additional Content
  4. Make sure you see a vertical tab for it in the Version details view
  5. Make sure you a container manifest list tab in CV version comparison screen when selecting and comparing 2 versions.

jeremylenz
jeremylenz reviewed Feb 9, 2024
View reviewed changes
Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version lists, content counts, vertical tabs, and CV version comparisons all work as expected. 👍

Some capitalization comments below :)

webpack/scenes/ContentViews/Details/Versions/Compare/CVVersionCompareConfig.js Outdated Show resolved Hide resolved
webpack/scenes/ContentViews/Details/Versions/Compare/CVVersionCompareConfig.js Outdated Show resolved Hide resolved
webpack/scenes/ContentViews/Details/Versions/VersionDetails/ContentViewVersionDetailConfig.js Outdated Show resolved Hide resolved
webpack/scenes/ContentViews/Details/Versions/VersionDetails/ContentViewVersionDetailConfig.js Outdated Show resolved Hide resolved
@sjha4 sjha4 force-pushed the cv_version_container_manifest branch from 7db8a51 to 6456c90 Compare February 12, 2024 17:19
jeremylenz
jeremylenz approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React failure unrelated. ACK, thanks @sjha4 !

@sjha4 sjha4 merged commit 8491ba0 into Katello:master Feb 14, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylenz jeremylenz jeremylenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjha4 @jeremylenz