Fixes #37170 - Remove Subscription-Entitlement notification #10892
Conversation
|
[test katello] |
sjha4
force-pushed
the
remove_subs_expiration_notification
branch
from
4513f5e
to
3c22483
Compare
| @pools = Katello::Pool.readable.expiring_in_days(days_from_now) | ||
| @affected_hosts = ::Host::Managed.with_pools_expiring_in_days(days_from_now) | ||
| end | ||
|
|
||
| if @affected_hosts.any? | ||
| start_report_task(days_from_now) | ||
| @report_url = report_url | ||
| @report_link = report_link |
There was a problem hiding this comment.
Now that I look at this closely, I wonder if we can keep this email notification after all, and just take out the @affected_hosts logic and the link to the report.. I think that since SCA won't help you when your subscriptions expire, having the email notification would still be useful (if it's not too much work to keep). It seems the actual list of subscriptions in this email depends on @pools and not @affected_hosts, so it should theoretically still work..
There was a problem hiding this comment.
Hmm..Ok..let me see if the reports can be updated to not have to refer to hosts..
|
Closing this out since there's been some design changes for this. We want to update this report and mailer to still have a subs expiring report which doesn't looks at entitlements. |
What are the changes introduced in this pull request?
Remove Subscription-Entitlement notifications.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Import a manifest on master branch and go to Foreman Tasks and check if you see SendExpireSoonNotifications scheduled task
Run db:migrate
Make sure the task is gone.