Fixes #37192 - Use with_enabled_email scope #10901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of typing out the same query explicitly.
sjha4
approved these changes
Feb 26, 2024
|
[test katello] |
1 similar comment
|
[test katello] |
qcjames53
pushed a commit
to qcjames53/katello
that referenced
this pull request
Mar 7, 2024
* Fixes #37192 - Use with_enabled_email scope Instead of typing out the same query explicitly. * Refs #37192 - Bump required foreman version (cherry picked from commit 1ace8e5)
qcjames53
added a commit
that referenced
this pull request
Mar 7, 2024
* Release 4.12.0-rc1 (#10909) * Fixes #37137 - Use insert_all when creating available module streams (#10878) * Fixes #37137 - Use insert_all when creating available module streams (cherry picked from commit 7458f70) * Fixes #37178 - use safe navigation for operatingsystem (#10897) (cherry picked from commit 664488d) * Refs #37202 - display name according to setting in host collection (cherry picked from commit de39a36) * Fixes #37192 - Use with_enabled_email scope (#10901) * Fixes #37192 - Use with_enabled_email scope Instead of typing out the same query explicitly. * Refs #37192 - Bump required foreman version (cherry picked from commit 1ace8e5) * Refs #37203 - display name according to setting in errata host list (cherry picked from commit 2775554) * Fixes #37214 - Change 'default' for limit to environment checkbox in activation-key and content-host (cherry picked from commit 9d0a338) * Fixes #37108 - Preload content_view_components (#10864) (cherry picked from commit d98c17b) * Fixes #36976 - Too many audit records slow down CV loading (#10911) (cherry picked from commit 30c6977) * Refs #37201 - display short host name in activation keys menu (cherry picked from commit 8164043) * Fixes #37187 - Update ACS refresh Pulp fixtures + fix repository_test test (cherry picked from commit 99c7857) * Fixes #37198 - Allow installedDeb package attributes in safemode (cherry picked from commit b5d785f) * Fixes #37197 - Kickstart repository correctly listed on hostgroup (cherry picked from commit 35c49b1) * Fixes #37169 - Managing a Hosts Repository Sets does not behave as expected (#10905) (cherry picked from commit 6420cf8) --------- Co-authored-by: Jeremy Lenz <[email protected]> Co-authored-by: Matěj Mudra <[email protected]> Co-authored-by: Adam Růžička <[email protected]> Co-authored-by: Manisha Singhal <[email protected]> Co-authored-by: Bernhard Suttner <[email protected]> Co-authored-by: Samir Jha <[email protected]> Co-authored-by: ianballou <[email protected]> Co-authored-by: Bernhard Suttner <[email protected]> Co-authored-by: Partha Aji <[email protected]> Co-authored-by: Thorben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of typing out the same query explicitly.
What are the changes introduced in this pull request?
Reusing a scope introduced in theforeman/foreman#9892 from foreman instead of doing the same thing explicitly.
What are the testing steps for this pull request?
Email notifications on capsule sync, cv promote, cv publish and repo sync should still work exactly as they did, but now with less code.