Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #37148 - Remove removed_widgets override #10927

Merged

Conversation

jeremylenz
Copy link
Member

What are the changes introduced in this pull request?

#10882 removed subscription-related widgets, but we still had some code that refers to them. This code was an override of Foreman's removed_widgets method and is no longer needed.

This is causing the Dashboard page to break with

uninitialized constant SUBSCRIPTION_TEMPLATES
Extracted source (around line #16):

        if Organization.current&.simple_content_access?
          widgets.reject! { |widget| ::Widget.singleton_class::SUBSCRIPTION_TEMPLATES.include? widget[:template] }
        end

        widgets

Rails.root: /home/vagrant/foreman

Application Trace | Framework Trace | Full Trace
/home/vagrant/katello/app/helpers/katello/concerns/dashboard_helper_extensions.rb:16:in `block in removed_widgets'

Considerations taken when implementing this change?

Both of the referenced widgets are removed, so removing this is correct

What are the testing steps for this pull request?

On master: Load the dashboard page. You will get that error.

On this branch: Load the dashboard page. You should get no error.

Copy link
Contributor

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue on my devel-forklift, thanks.

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! To reproduce, you must have some widgets that are deleted.

@jeremylenz jeremylenz merged commit 40a70ce into Katello:master Mar 13, 2024
22 checks passed
qcjames53 pushed a commit to qcjames53/katello that referenced this pull request Mar 19, 2024
qcjames53 added a commit that referenced this pull request Mar 19, 2024
* Refs #37148 - Remove removed_widgets override (#10927)

(cherry picked from commit 40a70ce)

* Fixes #35215 - Handle cloned hostgroups in hosts_and_hostgroups_helper (#10894)

(cherry picked from commit e3d46c6)

* Fixes #36979 - Remove cdn_ssl_version setting

This was originally added to allow downgrading the CDN connection
SSL version for compatibility with much older proxy servers. That
should be less of a concern now.

We do still set a value of TLS v1.2 for the min_version, but only
because ruby/openssl#709 prevents using
the system-wide crypto policy for now. In the future, that can be
removed as well, restoring control to the user at the OS level.

(cherry picked from commit 78fcba9)

* Fixes #37277 - Fix ACS randomly failing VCR tests (#10941)

(cherry picked from commit 6d93801)

* Fixes #37240 - Fix CCV duplicate repo warning (#10928)

(cherry picked from commit 02fc313)

---------

Co-authored-by: Jeremy Lenz <[email protected]>
Co-authored-by: William Bradford Clark <[email protected]>
Co-authored-by: Ian Ballou <[email protected]>
Co-authored-by: Markus Bucher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants