Fixes #37974 - support keep-latest-packages in python #11202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Nov 18, 2024
ianballou
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Functionally this is working well when combined with #11220
However, I found a UI bug. When you look at an existing repository that has a "Keep latest packages" value, the UI shows it as blank. This issue seems related only to generic content types that have integer fields.
I'm guessing the fix would live in /home/vagrant/katello/engines/bastion_katello/app/assets/javascripts/bastion_katello/products/details/repositories/details/repository-details-info.controller.js
ianballou
requested changes
Nov 20, 2024
The pulp python backend supports keep-latest-packages. This should be available on the UI, too.
ianballou
pushed a commit
to ianballou/katello
that referenced
this pull request
Dec 2, 2024
* Fixes #37974 - support keep-latest-packages in python The pulp python backend supports keep-latest-packages. This should be available on the UI, too. * Fixes generic_remote_options if there is no delimiter (cherry picked from commit 8201a7a)
ianballou
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Fixes #37974 - support keep-latest-packages in python The pulp python backend supports keep-latest-packages. This should be available on the UI, too. * Fixes generic_remote_options if there is no delimiter (cherry picked from commit 8201a7a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pulp python backend supports keep-latest-packages. This should be available on the UI, too.
Thanks @lumarel for adding the number content type some days ago. Very appreciated!