Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38038 - Show full GPG Key URL #11234

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

sbernhard
Copy link
Member

@sbernhard sbernhard commented Nov 22, 2024

In case you want to manually configure repositories provided by Katello and use GPG keys for them, its helpful to have the full GPG key URL on the repositories details page so that you can copy/paste it.

image

What are the changes introduced in this pull request?

  • Added field to have the full_gpg_key_url
  • Added this field on the API
  • Added this field on the UI

Considerations taken when implementing this change?

In case you want to manually configure repositories provided by Katello
and use GPG keys for them, its helpful to have the full GPG key URL on
the repositories details page so that you can copy/paste it.

What are the testing steps for this pull request?

In case you want to manually configure repositories provided by Katello
and use GPG keys for them, its helpful to have the full GPG key URL on
the repositories details page so that you can copy/paste it.
@sbernhard
Copy link
Member Author

Maybe a good candidate for you @chris1984 :)

@chris1984 chris1984 self-assigned this Nov 22, 2024
@chris1984
Copy link
Member

ACK, looks great. I will make a hammer pr to add the new field to hammer activation-key info

@chris1984
Copy link
Member

You have green button perms now, I will let you merge @sbernhard :)

@sbernhard
Copy link
Member Author

ACK, looks great. I will make a hammer pr to add the new field to hammer activation-key info

This would be nice. Thank you very much!

@sbernhard sbernhard merged commit 34d7f9c into Katello:master Nov 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants