CustomTkinter kullanarak GUI ekledim. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anime listing, episode listing, and episode streaming through mpv to-do: watch history better gui anime list pagination downloading
no more simultaneous streaming bug. fixed how pages work
…ith Fetch API
Previously, the `fetch_info` method in the `Anime` class used `execute_script` with `$.get` to fetch anime information. This approach caused a `JavascriptException` because:
- The `$.get` method is asynchronous, but `execute_script` expects synchronous execution.
- jQuery (`$`) might not be defined on the page, leading to an undefined reference.
To resolve this issue, the `fetch_info` method has been modified to use `execute_async_script` with the Fetch API, which handles asynchronous operations properly.
**Changes Made:**
- Replaced the use of `execute_script` with `execute_async_script` to accommodate asynchronous execution.
- Utilized the Fetch API to perform a GET request to `/anime/{self.slug}`.
- Implemented a callback function to return the fetched data back to the Python code.
- Added error handling to catch any exceptions during the fetch operation and return `null` if the fetch fails.
- Checked if the returned data is `None` and raised an exception if necessary.
**Benefits:**
- Fixes the `JavascriptException` caused by the improper handling of asynchronous JavaScript code.
- Eliminates the dependency on jQuery, ensuring compatibility even if jQuery is not loaded on the page.
- Enhances the reliability of fetching anime information by correctly handling asynchronous requests.
**Tested By:**
- Running the application and selecting various anime to ensure that the episode lists load correctly without errors.
- Verifying that the error no longer occurs and that the application functions as expected.
**References:**
- Selenium documentation on `execute_async_script`: https://selenium-python.readthedocs.io/api.html#selenium.webdriver.remote.webdriver.WebDriver.execute_async_script
- Fetch API documentation: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch
This commit ensures that the anime information is fetched reliably and resolves the issues related to asynchronous JavaScript execution.
|
Çaban için teşekkürler, üstünde baya vakit harcamışsın gibi görünüyor. Repo'nu çalıştıramadım: Eğer ufak sorunları giderip çalışır vaziyete getirirsen bu repo'nun README kısmına yönlendirici bir link koyabilirim. Senin fork'ta bir de pek çok silinmesi gereken dosya var .zip, .toc, .pyc, .pkg, .html uzantılı Tekrardan eforların için teşekkür ederim ama, kulağa güzel geliyor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bu fork ile projeye ctk kullanarak projeye gui ekledim. cli ile yapılabilen çoğu şey gui üzerinden yapılabiliyor. gelecekte ayarlar sekmesi ekleyeceğim