Skip to content

Commit

Permalink
run subprocess with shell set to false
Browse files Browse the repository at this point in the history
  • Loading branch information
ca77y committed Mar 31, 2015
1 parent 9ca7d54 commit 73eef7f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 5 additions & 4 deletions android_clean_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ def add_element(self, message):
bits = res.split('.')[-2:]
self.elements.append((bits[0], bits[1]))
else:
print("The pattern '%s' seems to find nothing in the error message '%s'. We can't find the resource and can't remove it. The pattern might have changed, please check and report this in github issues." % (Issue.pattern, message))
print("The pattern '%s' seems to find nothing in the error message '%s'. We can't find the resource and can't remove it. The pattern might have changed, please check and report this in github issues." % (
Issue.pattern, message))


def parse_args():
Expand Down Expand Up @@ -74,10 +75,10 @@ def run_lint_command():
lint, app_dir, lint_result, ignore_layouts = parse_args()
if not lint_result:
lint_result = os.path.join(app_dir, 'lint-result.xml')
call_result = subprocess.call([lint, app_dir, '--xml', lint_result], shell=True)
call_result = subprocess.call([lint, app_dir, '--xml', lint_result])
if call_result > 0:
print('Running the command failed. Try running it from the console. Arguments for subprocess.call: {0}'.format(
[lint, app_dir, '--xml', lint_result]))
print('Running the command failed with result {}. Try running it from the console. Arguments for subprocess.call: {}'.format(
call_result, [lint, app_dir, '--xml', lint_result]))
return lint_result, app_dir, ignore_layouts


Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import sys
from setuptools import setup, find_packages

version = '0.1.2'
version = '0.1.3'

def read(f):
return open(os.path.join(os.path.dirname(__file__), f)).read().strip()
Expand Down

0 comments on commit 73eef7f

Please sign in to comment.