Support removal of arrays #14
Conversation
|
Just fixed a little error, sorry about that |
timrae
force-pushed
the
patch-1
branch
2 times, most recently
from
c4b8604
to
cbc0b3b
Compare
|
I am getting this error: |
|
Oops I think I had pasted the patch via the web interface... Looks like I forgot something. I'll edit soon |
Match patterns such as "string-array" that would previously only return "array", and subsequently fail in `remove_resource_value` Add string-array to test app
|
I added the missing lines but that's broken the unit tests... I'll have to take a look later as I don't have time at the moment. Feel free to fix it up yourself and close the PR if you have time |
|
Hi @timrae |
|
@philippb sorry I don't have time at the moment. I briefly looked into it at the time of posting and it seemed non-trivial so I never ended up getting around to it. I might do it sometime next year if I end up needing to use the script again. I'd recommend fixing it yourself if you have the time and motivation! |
|
@timrae thanks for the reply. We'll look into it. |
|
Right now we don't have the time to fix this, it's worth looking into in the future |
Match patterns such as "string-array" that would previously only return "array", and subsequently fail in
remove_resource_value