Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): omit null value from book.json #5

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix(config): omit null value from book.json #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,23 @@ let plantUMLServer: PlantUMLServer | null = null;
let libConfig: LibConfig | null = null;
let classConfig: ClassConfig | null = null;

const mergeConfig = (
defaultConfig: PluginConfig,
config: Partial<PluginConfig>,
): PluginConfig => ({
...defaultConfig,
...Object.fromEntries(
Object.entries(config).filter((_, value) => null != value),
),
});

export const hooks = {
init: function (this: any) {
const mergedConfig = Object.assign(
{},
defaultConfig,
this.config.get('pluginsConfig.plantuml-server') as PluginConfig,
const mergedConfig = mergeConfig(defaultConfig, {
...this.config.get('pluginsConfig.plantuml-server'),
// ebook-convert cannot handle svg format data-uri, so it is forced to change to png
this.output.name === 'ebook' ? { format: 'png' } : {},
);
...(this.output.name === 'ebook' ? { format: 'png' } : {}),
});

libConfig = {
optimizeImage: mergedConfig.optimizeImage,
Expand Down