Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Attention][Feature] Rewrite config #21

Merged
merged 25 commits into from
Feb 13, 2025
Merged

[Attention][Feature] Rewrite config #21

merged 25 commits into from
Feb 13, 2025

Conversation

AmarokIce
Copy link
Contributor

Rewrite all config.

@RawDiamondMC
Copy link
Member

Oh my god conflict

@RawDiamondMC RawDiamondMC self-requested a review December 24, 2024 14:40
@AmarokIce
Copy link
Contributor Author

Oh my god conflict

I didn't know why the file i removed but it still conflict hum

AmarokIce
AmarokIce commented Dec 24, 2024
View reviewed changes
Copy link
Contributor Author

@AmarokIce AmarokIce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my god conflict

All right I fix it

AmarokIce
AmarokIce commented Dec 25, 2024
View reviewed changes
Copy link
Contributor Author

@AmarokIce AmarokIce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK now it can merge

@RawDiamondMC
Copy link
Member

Cool

RawDiamondMC
RawDiamondMC requested changes Feb 1, 2025
View reviewed changes
Copy link
Member

@RawDiamondMC RawDiamondMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code

Note we are already in band.kessoku.lib.api.config, don't create another api package

Also I cannot understand how to use ArrayValue and MapValue? Can you write some examples about how to use them since they are different from other config values

RawDiamondMC
RawDiamondMC approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@RawDiamondMC RawDiamondMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RawDiamondMC RawDiamondMC merged commit e7cf585 into dev/1.21 Feb 13, 2025
@RawDiamondMC RawDiamondMC deleted the dev/config branch February 13, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RawDiamondMC RawDiamondMC RawDiamondMC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmarokIce @RawDiamondMC