fix custom keycode enum in keychron_common.h #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokher
reviewed
Feb 29, 2024
tam1m
force-pushed
the
wireless_playground
branch
2 times, most recently
from
4e46b1b to
60366a0
Compare
…o not define ANANLOG_MATRIX and or LK_WIRELESS_ENABLE. Assigning KC_TRANS here breaks NEW_SAFE_RANGE. Also fix typo in ANANLOG_MATRIX
…or ANANLOG_MATRIX are not defined see: https://github.com/Keychron/qmk_firmware/pull/222/files#r1507606593 Co-authored-by: lokher <[email protected]>
tam1m
force-pushed
the
wireless_playground
branch
from
60366a0 to
0cddb71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the KC_TRANS assignments for keys not existing on keyboards that do not define ANANLOG_MATRIX and or LK_WIRELESS_ENABLE.
Assigning KC_TRANS here breaks NEW_SAFE_RANGE since NEW_SAFE_RANGE now eqals
KC_TRANS + 1 = 0x2instead of QK_KB_NN where NN is the next unused value in the QK_KB range.Also fix typo in ANANLOG_MATRIX