Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the URL builder in routes #270

Open
Gauravjeetsingh opened this issue Jun 21, 2023 · 0 comments
Open

Use the URL builder in routes #270

Gauravjeetsingh opened this issue Jun 21, 2023 · 0 comments

Comments

@Gauravjeetsingh
Copy link
Collaborator

Gauravjeetsingh commented Jun 21, 2023

from controller/shabad.js

    resultsInfo.pages.nextPage = `${req.protocol}://${req.get('host')}${req.baseUrl}${
            req.path
          }?${Object.keys(req.query)
            .map(key => `${key}=${encodeURIComponent(req.query[key])}`)
            .join('&')}`;

Maybe we can divide this into two different statements (for base path and query keys.

Also, can we use a URL builder instead?

Something like:

const url = require('url');
const myURL = url.format({
  protocol: req.protocol,
  hostname: req.get('host'),
  pathname: '/some/path',
  query: {
    key: 'value'
  }
});

Originally posted by @mandeepryaz in #268 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant