Add an endpoint to show specific verses #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release doc updates
Fix doc servers
* Add ssl cert config for skysql * Fix linting error and import fs module * convert serverCert to string from an array * Added ability to use cluster pools or not (KhalisFoundation#256) * Added ability to use cluster pools or not (checks if DB_NODES array exists) Also added ability to optionally use SSL_CA cert for connection * Added ability to use cluster pools or not (checks if DB_NODES array exists) Also added ability to optionally use SSL_CA cert for connection Co-authored-by: Gauravjeet Singh <[email protected]>
…ction-pool-crash Hotfix: change connection end to release (KhalisFoundation#260)
mandeepryaz
requested changes
Jun 14, 2023
This was referenced Jun 22, 2023
mandeepryaz
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement the semantic search API, we needed an endpoint that returns all the banidb details of specific verses.
This PR adds endpoint /search-results which take comma separated verse ids as parameter, VerseID and returns all the information required to show those verses as search results.
Data at endpoint
/v2/search-results/212,1231Sidenote: Also, pulled the commits from master branch here, so that dev is upto date with master branch commits.