Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the styles, and make it compatible with video themes. #53

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix the styles, and make it compatible with video themes. #53

wants to merge 8 commits into from

Conversation

Gauravjeetsingh
Copy link
Contributor

No description provided.

@inderpreetsingh
Copy link
Contributor

@Gauravjeetsingh its missing the video files in this PR, you need to add those in src folder too, and get them to build using webpack.

@inderpreetsingh inderpreetsingh self-requested a review December 5, 2023 06:56
inderpreetsingh
inderpreetsingh requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@inderpreetsingh inderpreetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update webpack config to include video files in build

@Gauravjeetsingh
Copy link
Contributor Author

Removed videos from chromecast, and instead used screenshot of video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inderpreetsingh inderpreetsingh inderpreetsingh requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gauravjeetsingh @inderpreetsingh