Add concurrency to cancel stale gerald pr runs in gerald-pr.yml #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Pull request shouldn't bother with stale Gerald notification runs when they've already been updated (and possibly corrected). Gerald currently triggers for `edited, opened, reopened, ready_for_review, synchronize` and a user can very quickly trigger all of them... which currently plod along in parallel wasting money, and repeatedly notifying the same people on Slack (depending on their settings). TYPE | DESCRIPTION -- | -- opened | pull request is created edited | title, body, or the base branch of the PR is modified ready_for_review | pull request is taken out from draft mode reopened | closed pull request is reopened synchronize | commit(s) pushed to the pull request Signed-off-by: Steve Coffman <[email protected]>
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
See Khan/webapp#20006 |
jeresig
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Pull request shouldn't bother with stale Gerald notification runs when they've already been updated (and possibly corrected). Gerald currently triggers for
edited, opened, reopened, ready_for_review, synchronizeand a user can very quickly trigger all of them... which currently plod along in parallel wasting money, and repeatedly notifying the same people on Slack (depending on their settings).