MathJax: Add condition for Math expression parsing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously thought (and Khanmigo is prompted) that expression should use `\(...\)` - but in real life we also have seen `\[...\]` for the wrapping of MathJax. This is a simple fix for that, as well as adding a test case for it in our task.json ensure it works. Test Plan: Run `yarn start` to ensure that expression display, as well as highlighting works with the other type of expressions.
khan-actions-bot
pushed a commit
to Khan/label-studio
that referenced
this pull request
Jul 25, 2024
…f6b14b8719ff0289a0945cfad897a232b8f0 at Khan/label-studio-frontend#11 Workflow run: https://github.com/Khan/label-studio/actions/runs/10086097185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We previously thought (and Khanmigo is prompted) that expression
should use
\(...\)- but in real life we also have seen\[...\]for the wrapping of MathJax.
This is a simple fix for that, as well as adding a test case for it
in our task.json ensure it works.
This also fixes an issue for Firefox when we see browser misrendering,
which we can retry by
clearTypeset.Test Plan:
Run
yarn startto ensure that expression display, as well as highlightingworks with the other type of expressions.