Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation for RichTextTable component #3

Merged
merged 11 commits into from
Aug 14, 2023
Merged

Conversation

dat-boris
Copy link
Collaborator

@dat-boris dat-boris commented Aug 10, 2023

Summary:

Previously although RichTextTable display properly, the annotation
didn't work.

This PR is a result of a bunch of learning on how the registry works,
and realize a bunch of small things that we did wrong and need to hook up
properly. These will be documented in our documentation [1].

[1] https://khanacademy.atlassian.net/wiki/spaces/INFRA/pages/2373714068/Label+Studio+Frontend+guide#Note%3A-Adding-new-components-need-to-update-registry-and-Mobx-types

Issue: https://khanacademy.atlassian.net/browse/DI-533

Test plan:

label-demo

Previously although RichTextTable display properly, the annotaiton
didn't work right.

This PR is a result of a bunch of learning on how the registry works,
and realiase a few small things that we did wrong and need to hook up
properly.  These will be documented in our documentation [1].

[1] https://khanacademy.atlassian.net/wiki/spaces/INFRA/pages/2373714068/Label+Studio+Frontend+guide

Issue: https://khanacademy.atlassian.net/browse/DI-533

Test plan:
- `yarn start` and goes to https://localhost:3000, and try out the
  annotation.
@dat-boris dat-boris self-assigned this Aug 10, 2023
@dat-boris dat-boris marked this pull request as ready for review August 10, 2023 22:33
@dat-boris
Copy link
Collaborator Author

Huh - the E2E test failure is worth debugging (I will circle back tmr)

  1) Date Time
       Check DateTime holds state between annotations and saves result:
     TypeError: s.updateGlobalOffsets is not a function
      at /home/runner/work/label-studio-frontend/label-studio-frontend/e2e/plugins/errorsCollector.js:175:16

I have no idea what the cypress test failure is, looks like it is a dependency failure.

Copy link

@wwells wwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thank you for the clear linked FE documentation. Great anchor as we start building out more documentation over the coming sprints. Especially key for our team of not FE engineers ;)

@wwells
Copy link

wwells commented Aug 11, 2023

PS: I added a placeholder note to the one-pager that once this is deployed we should validate using this by updating existing workflows and making sure our import/export commands still work....

@dat-boris dat-boris marked this pull request as draft August 11, 2023 19:24
@dat-boris dat-boris marked this pull request as ready for review August 11, 2023 19:24
@dat-boris dat-boris mentioned this pull request Aug 11, 2023
@dat-boris
Copy link
Collaborator Author

Woohoo, check pass! Landing now.

image

@dat-boris dat-boris merged commit 7f85226 into master Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants