-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix annotation for RichTextTable component #3
Conversation
Previously although RichTextTable display properly, the annotaiton didn't work right. This PR is a result of a bunch of learning on how the registry works, and realiase a few small things that we did wrong and need to hook up properly. These will be documented in our documentation [1]. [1] https://khanacademy.atlassian.net/wiki/spaces/INFRA/pages/2373714068/Label+Studio+Frontend+guide Issue: https://khanacademy.atlassian.net/browse/DI-533 Test plan: - `yarn start` and goes to https://localhost:3000, and try out the annotation.
Huh - the E2E test failure is worth debugging (I will circle back tmr)
I have no idea what the cypress test failure is, looks like it is a dependency failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thank you for the clear linked FE documentation. Great anchor as we start building out more documentation over the coming sprints. Especially key for our team of not FE engineers ;)
|
Summary:
Previously although RichTextTable display properly, the annotation
didn't work.
This PR is a result of a bunch of learning on how the registry works,
and realize a bunch of small things that we did wrong and need to hook up
properly. These will be documented in our documentation [1].
[1] https://khanacademy.atlassian.net/wiki/spaces/INFRA/pages/2373714068/Label+Studio+Frontend+guide#Note%3A-Adding-new-components-need-to-update-registry-and-Mobx-types
Issue: https://khanacademy.atlassian.net/browse/DI-533
Test plan:
yarn start
and goes to https://localhost:3000, and try out theannotation.