Update pairs documentation #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folmos-at-orange
force-pushed
the
243-improve-specific_pairs-documentation
branch
from
1ba74d2 to
bf157b4
Compare
popescu-v
reviewed
Dec 12, 2024
popescu-v
reviewed
Dec 12, 2024
popescu-v
reviewed
Dec 12, 2024
khiops/sklearn/estimators.py
Outdated
| which jointly are more informative that its univariate components may be taken | ||
| into account in the classifier. | ||
| Maximum number of pair features to construct. These features are a 2D grid | ||
| partition feature pair. The grid is optimized such that in each cell the target |
There was a problem hiding this comment.
s/partition feature pair/partition of the domain of a feature pair/
There was a problem hiding this comment.
I eliminated "domain" because is too verbose (two "of" one after another). That the partition is in the domain is implied by the the 2D grid part, there is no ambiguity. I'll add the missing "the" nonetheless.
popescu-v
reviewed
Dec 12, 2024
khiops/sklearn/estimators.py
Outdated
| Maximum number of pair features to construct. These features are a 2D grid | ||
| partition feature pair. The grid is optimized such that in each cell the target | ||
| distribution is well approximated by a constant histogram. Only pairs that are | ||
| jointly more informative than its marginals may be taken into account in the |
There was a problem hiding this comment.
s/than its marginals/than their marginals/
(the pairs' marginals)
popescu-v
reviewed
Dec 12, 2024
| containing it (within the maximum limit ``n_pairs``). These pairs have top | ||
| priority: they are constructed first. | ||
| all_possible_pairs : bool, default ``True`` | ||
| If ``True`` tries to create all possible pairs within the limit ``n_pairs``. |
There was a problem hiding this comment.
s/within the limit/within the maximum limit/
popescu-v
reviewed
Dec 12, 2024
khiops/sklearn/estimators.py
Outdated
| which jointly are more informative that its univariate components may be taken | ||
| into account in the regressor. | ||
| Maximum number of pair features to construct. These features are a 2D grid | ||
| partition feature pair. The grid is optimized such that in each cell the target |
There was a problem hiding this comment.
s/partition feature pair/partition of the domain of a feature pair/
popescu-v
reviewed
Dec 12, 2024
khiops/sklearn/estimators.py
Outdated
| Maximum number of pair features to construct. These features are a 2D grid | ||
| partition feature pair. The grid is optimized such that in each cell the target | ||
| distribution is well approximated by a constant histogram. Only pairs that are | ||
| jointly more informative than its marginals may be taken into account in the |
There was a problem hiding this comment.
s/than its marginals/than their marginals/
popescu-v
reviewed
Dec 12, 2024
| containing it (within the maximum limit ``n_pairs``). These pairs have top | ||
| priority: they are constructed first. | ||
| all_possible_pairs : bool, default ``True`` | ||
| If ``True`` tries to create all possible pairs within the limit ``n_pairs``. |
There was a problem hiding this comment.
s/within the limit/within the maximum limit/
popescu-v
reviewed
Dec 12, 2024
khiops/sklearn/estimators.py
Outdated
| partition of the domain of a pair of features in which is optimized in a way | ||
| that the cells are the purest possible with respect to the target. | ||
| Maximum number of pair features to construct. These features are a 2D grid | ||
| partition feature pair. The grid is optimized such that in each cell the target |
There was a problem hiding this comment.
s/partition feature pair/partition of the domain of a feature pair/
popescu-v
reviewed
Dec 12, 2024
khiops/sklearn/estimators.py
Outdated
| Maximum number of pair features to construct. These features are a 2D grid | ||
| partition feature pair. The grid is optimized such that in each cell the target | ||
| distribution is well approximated by a constant histogram. Only pairs that are | ||
| jointly more informative than its marginals may be taken into account in the |
There was a problem hiding this comment.
s/than its marginals/than their marginals/
popescu-v
reviewed
Dec 12, 2024
| containing it (within the maximum limit ``n_pairs``). These pairs have top | ||
| priority: they are constructed first. | ||
| all_possible_pairs : bool, default ``True`` | ||
| If ``True`` tries to create all possible pairs within the limit ``n_pairs``. |
There was a problem hiding this comment.
s/within the limit/within the maximum limit/
popescu-v
requested changes
Dec 12, 2024
nairbenrekia
approved these changes
Dec 13, 2024
folmos-at-orange
force-pushed
the
243-improve-specific_pairs-documentation
branch
from
bf157b4 to
39b3021
Compare
- Remove "source_repository" setting - It generated a link to a 404 page in Github - Change the Github icon to khiops-python
folmos-at-orange
force-pushed
the
243-improve-specific_pairs-documentation
branch
from
14ba038 to
e947fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put your message here
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html