Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

310 eliminate pair support from khiopsregressor #313

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

310 eliminate pair support from khiopsregressor #313

wants to merge 3 commits into from

Conversation

folmos-at-orange
Copy link
Member

commit 3eb545c (HEAD -> 310-eliminate-pair-support-from-khiopsregressor, origin/310-eliminate-pair-support-from-khiopsregressor)
Author: Felipe Olmos [email protected]
Date: Thu Dec 12 15:57:24 2024 +0100

Remove n_pairs parameter from KhiopsRegressor

It was never supported.

commit 1ba74d2
Author: Felipe Olmos [email protected]
Date: Thu Dec 12 15:56:51 2024 +0100

Update pairs documentation

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@folmos-at-orange folmos-at-orange linked an issue Dec 16, 2024 that may be closed by this pull request
Eliminate pair support from KhiopsRegressor #310
Open
@folmos-at-orange folmos-at-orange requested review from popescu-v and nairbenrekia and removed request for nairbenrekia December 16, 2024 11:05
@folmos-at-orange folmos-at-orange self-assigned this Dec 16, 2024
@folmos-at-orange folmos-at-orange force-pushed the 310-eliminate-pair-support-from-khiopsregressor branch from 3eb545c to faf9b44 Compare December 19, 2024 18:06
@folmos-at-orange
Update pairs documentation
b11b366
@folmos-at-orange
Update Sphinx configuration
e947fea 
- Remove "source_repository" setting
 - It generated a link to a 404 page in Github
- Change the Github icon to khiops-python
@folmos-at-orange
Remove n_pairs parameter from KhiopsRegressor
860e5ce 
It was never supported.
@folmos-at-orange folmos-at-orange force-pushed the 310-eliminate-pair-support-from-khiopsregressor branch from faf9b44 to 860e5ce Compare December 20, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popescu-v popescu-v Awaiting requested review from popescu-v

At least 1 approving review is required to merge this pull request.

Assignees

@folmos-at-orange folmos-at-orange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate pair support from KhiopsRegressor
1 participant
@folmos-at-orange