Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

310 eliminate pair support from khiopsregressor #313

Merged
merged 1 commit into from
Jan 8, 2025
Merged

310 eliminate pair support from khiopsregressor #313

merged 1 commit into from
Jan 8, 2025

Conversation

folmos-at-orange
Copy link
Member

@folmos-at-orange folmos-at-orange commented Dec 16, 2024 •
edited
Loading

commit 3eb545c (HEAD -> 310-eliminate-pair-support-from-khiopsregressor, origin/310-eliminate-pair-support-from-khiopsregressor)
Author: Felipe Olmos [email protected]
Date: Thu Dec 12 15:57:24 2024 +0100

Remove n_pairs parameter from KhiopsRegressor

It was never supported.

commit 1ba74d2
Author: Felipe Olmos [email protected]
Date: Thu Dec 12 15:56:51 2024 +0100

Update pairs documentation

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@folmos-at-orange folmos-at-orange linked an issue Dec 16, 2024 that may be closed by this pull request
Eliminate pair support from KhiopsRegressor #310
Closed
@folmos-at-orange folmos-at-orange requested review from popescu-v and nairbenrekia and removed request for nairbenrekia December 16, 2024 11:05
@folmos-at-orange folmos-at-orange self-assigned this Dec 16, 2024
@folmos-at-orange folmos-at-orange force-pushed the 310-eliminate-pair-support-from-khiopsregressor branch 2 times, most recently from faf9b44 to 860e5ce Compare December 20, 2024 10:05
@folmos-at-orange
Copy link
Member Author

Waiting for #311 to be merged.

@popescu-v
Copy link
Collaborator

Waiting for #311 to be merged.

I think it can be, as of now.

popescu-v
popescu-v requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@popescu-v popescu-v left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factor out pair-specific checks so that they can be mutualized between the KhiopsClassifier and the KhiopsEncoder.
Rebase on dev.

@folmos-at-orange folmos-at-orange force-pushed the 310-eliminate-pair-support-from-khiopsregressor branch 2 times, most recently from 44aa9cb to ee79c10 Compare January 8, 2025 12:12
@folmos-at-orange folmos-at-orange force-pushed the 310-eliminate-pair-support-from-khiopsregressor branch from ee79c10 to e187e81 Compare January 8, 2025 13:09
popescu-v
popescu-v approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@folmos-at-orange folmos-at-orange merged commit bd9843e into dev Jan 8, 2025
19 checks passed
@folmos-at-orange folmos-at-orange deleted the 310-eliminate-pair-support-from-khiopsregressor branch January 8, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popescu-v popescu-v popescu-v approved these changes

Assignees

@folmos-at-orange folmos-at-orange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate pair support from KhiopsRegressor
2 participants
@folmos-at-orange @popescu-v