Skip to content

Commit

Permalink
Use pull_request trigger in workflows
Browse files Browse the repository at this point in the history
A pull_request event is better suited than push event for our purposes.
A push event is triggered not only when pushing but when merging via the
GH web interface.
  • Loading branch information
folmos-at-orange committed Oct 26, 2023
1 parent a21be1c commit 2db95c3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/pack-debian.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
name: Create Debian package
on:
workflow_dispatch:
pull_request:
paths: ['**CMakeLists.txt', '**.cmake']
jobs:
build-deb-package:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -90,7 +92,7 @@ jobs:
run: |
khiops -v
khiops_coclustering -v
- name: Test Khiops and Khiops Coclustering
- name: Test Khiops installation
uses: ./.github/actions/test-khiops-install
test-kni-deb:
needs: build-deb-package
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pack-rpm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
name: Create RPM package
on:
workflow_dispatch:
pull_request:
paths: ['**CMakeLists.txt', '**.cmake']
jobs:
build-rpm-package:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -88,7 +90,7 @@ jobs:
- name: Install Khiops Desktop (with java)
run: |
yum install -y ./artifacts/khiops-*
- name: Test Khiops and Khiops Coclustering
- name: Test Khiops installation
uses: ./.github/actions/test-khiops-install
test-kni-rpm:
needs: build-rpm-package
Expand Down Expand Up @@ -122,5 +124,5 @@ jobs:
uses: actions/checkout@v3
with:
sparse-checkout: .github
- name: Test KNI package
- name: Test KNI package installation
uses: ./.github/actions/test-kni
1 change: 0 additions & 1 deletion .github/workflows/pre-commit-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
name: Run pre-commit checks
on:
pull_request:
push:
workflow_dispatch:
jobs:
pre-commit-checks:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Run Unit Tests
on:
workflow_dispatch:
push:
pull_request:
paths:
- '**CMakeLists.txt'
- src/**.h
Expand Down

0 comments on commit 2db95c3

Please sign in to comment.