120 jar files are not present in the ubuntu debian khiops desktop packages #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popescu-v
force-pushed
the
120-jar-files-are-not-present-in-the-ubuntu-debian-khiops-desktop-packages
branch
4 times, most recently
from
280f451 to
0a29212
Compare
folmos-at-orange
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Can't we make the same trick for as in build-linux-pack-containers.yml for GH_REPOSITORY ?
There was a problem hiding this comment.
I don't see how, because in that other case, I had added a preliminary stage doing this. Whereas here, we would need this variable from the outset (before any job stage is executed).
There was a problem hiding this comment.
Ok, let's leave it like that for the moment.
I would too, but I wanted to make sure we agree on this before squashing. |
GitHub workflow syntax does not provide a means of inlining string manipulations. Hence: - when needed in a job step, a step has been added for generating environment variable which lowercases the path to the repository - when needed in a job specification, the path has been reverted to its hard-coded lowercased version.
folmos-at-orange
approved these changes
Jan 12, 2024
popescu-v
force-pushed
the
120-jar-files-are-not-present-in-the-ubuntu-debian-khiops-desktop-packages
branch
from
0a29212 to
586fc94
Compare
popescu-v
deleted the
120-jar-files-are-not-present-in-the-ubuntu-debian-khiops-desktop-packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #120