-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 10.2.0 #165
Merged
Merged
Release 10.2.0 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nch-on-ubuntu Fix JAVA_HOME setting in Debian post-install script
* Use the right communicator "max error flow" messages were not received and remained in the communicator * code simplification We use the working slave list instead of the content of the task communicator. It is the right way because we send messages in the world comm and not in the task comm. * Add BugMPIWithErrors in LearningTest/Standard
This allows to cancel any ongoing run of the workflow if it is in the same PR or git reference. This is to enable faster development cycles in the CI by not having to cancel runs manually.
We add a release job that is only executed when the workflow executed on a tag (either by pushing or by manual execution). The workflow creates the release as a pre-release so it does not disturb the current stable one in the github page. The workflow may be executed many times as long as the release stays in the "pre-release" state. In the release step, we rename the package file names so their version match the tag. For now, the maintainers must check the coherence of the "source version" (that in KWKhiopsVersion.cpp) when creating a release. The release step depends only ond the build step and the tests steps are now allowed to fail. It is to maintainers to clean any defectiva package from a final release. Other opportunistic changes in this commit: - Update to version 4 of actions checkout, upload-artifact and download-artifact. This is to avoid deprecation warnings and in the case of dowload-artifact it even necessary as we use the new "pattern" option. - Simplify names of workflows and jobs so they are better seen in the "checks" box and tab of a PR. The verbose steps names are kept. This is to achieve a good compromise between legibility in the GitHub webUI and auto-documentation.
…upload-to-a-release Add release to package build CICD
bruno-at-orange
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.