-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
183 transform the basetest binary into unit tests #194
183 transform the basetest binary into unit tests #194
Conversation
bruno-at-orange
commented
Mar 18, 2024
- Add all methods of basetest in unit tests (except 2 with GUI)
- Add 2 methods of Learning in unit tests (one is buggy with an assertion and is commented)
- mv unit test directories to test/UnitTests
- set TESTING option default to ON in the preset (and add -DTESTING=OFF when it is needed in the actions)
- Improve the testing action in order to handle crashes in the unit test macro (assertion). results files are available for download, when test fails
Improve the file comparaison to be resilient with the '\' char when it is not a path separator Export all methods implements in the basetest binary to the base library (except the UI tests) Add unit tests for all methods run in basetest binary (except the UI) Add reference files for the new tests
The SYS token could be placed in the middle of the line. The part of the lines after this token will not be tested Finalisation de TestServices: - nettoyage des fins de ligne - utilisation d'un buffer de grande taille pour pouvoir stocker un path
Mise en place des test unitaires pour Learning - une famille de test par librairie - initialise avec deux tests pour KWData et deux tests pour KWDataPreparation - Le test de KWProbabilityTable est commenté car il lèv eune assertion - on peut maintenant integrer les tests unitaires un a un, librairie par librairie
Search assert check, require in results file and echo if it appears
35a435a
to
de3dd79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/Norm/base/ALString.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ligne 8: corriger le caractere accentué qui ne passe pas
de3dd79
to
cfc85c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it could be squashed when merging.
cfc85c5
to
ffd1993
Compare