Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

183 transform the basetest binary into unit tests #194

Merged

Conversation

bruno-at-orange
Copy link
Contributor

  • Add all methods of basetest in unit tests (except 2 with GUI)
  • Add 2 methods of Learning in unit tests (one is buggy with an assertion and is commented)
  • mv unit test directories to test/UnitTests
  • set TESTING option default to ON in the preset (and add -DTESTING=OFF when it is needed in the actions)
  • Improve the testing action in order to handle crashes in the unit test macro (assertion). results files are available for download, when test fails

bruno-at-orange and others added 6 commits March 18, 2024 15:41
Improve the file comparaison to be resilient with the '\' char when it is not a path separator
Export all methods implements in the basetest binary to the base library (except the UI tests)
Add unit tests for all methods run in basetest binary (except the UI)
Add reference files for the new tests
The SYS token could be placed in the middle of the line. The part of the lines after this token will not be tested

Finalisation de TestServices:
- nettoyage des fins de ligne
- utilisation d'un buffer de grande taille pour pouvoir stocker un path
Mise en place des test unitaires pour Learning
- une famille de test par librairie
- initialise avec deux tests pour KWData et deux tests pour KWDataPreparation
- Le test de KWProbabilityTable est commenté car il lèv eune assertion
- on peut maintenant integrer les tests unitaires un a un, librairie par librairie
Search assert check, require in results file and echo if it appears
@bruno-at-orange bruno-at-orange linked an issue Mar 18, 2024 that may be closed by this pull request
@bruno-at-orange bruno-at-orange force-pushed the 183-transform-the-basetest-binary-into-unit-tests branch 3 times, most recently from 35a435a to de3dd79 Compare March 18, 2024 15:51
Copy link
Collaborator

@marcboulle marcboulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ligne 8: corriger le caractere accentué qui ne passe pas

@bruno-at-orange bruno-at-orange force-pushed the 183-transform-the-basetest-binary-into-unit-tests branch from de3dd79 to cfc85c5 Compare March 18, 2024 16:47
Copy link
Member

@folmos-at-orange folmos-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it could be squashed when merging.

test/Norm/CMakeLists.txt Show resolved Hide resolved
test/Utils/TestServices.h Outdated Show resolved Hide resolved
.github/workflows/run-unit-tests.yml Show resolved Hide resolved
CMakePresets.json Show resolved Hide resolved
@bruno-at-orange bruno-at-orange force-pushed the 183-transform-the-basetest-binary-into-unit-tests branch from cfc85c5 to ffd1993 Compare March 19, 2024 10:48
@bruno-at-orange bruno-at-orange merged commit 3f9f67c into dev Mar 19, 2024
53 checks passed
@bruno-at-orange bruno-at-orange deleted the 183-transform-the-basetest-binary-into-unit-tests branch March 19, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform the basetest binary into unit tests
3 participants