10.2.1 #208
Merged
10.2.1 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-work Fix tag release triggers
* Update KNI-tutorial Add installation notes for windows and Linux Remove the `v` in the tag id when updating the repo Update the README of the tutorial * Add kni in pack-nsis Add the java test on windows and linux and remove the action nvoxland/jar-download-action. It works only on Linux, I replaced it with a simple curl. * Use scripts to run Java test of KNI Test displayed in the tutorial are now run in the CI test * Add a job to test KNI in pack-nsis * Update docker files: add curl, remove wget remove the custom installation of cmake in rocky8 because cmake is now up-to-date with dnf
When launching Khiops with GUI in windows the `jvm.dll` library is loaded. This library has as dependency `vcruntime140.dll` (Visual C Runtime) which is usually installed by default in Windows. In case it is not installed Khiops failed without any meaningful message. To fix this, in the launcher script: - We add %JAVA_HOME%\bin to the path so `vcruntime140.dll` is always found (JRE bundles it). - We add a new error window that is launched when Khiops exits with return code different from 0 o 2, showing the log.
…k-on-some-machine-under-windows-11 Fix jvm dependency lib not being found in Windows
In the class PLMPISystemFileDriverRemote, we use a new class attribute nLocalErrno to store errno code. We can not relies on the global errno for file access because MPI_Recv modifies errno (sets it to 11, Resource Temporarily Unavailable) even if all is OK.
The version macros definitions were being "fixed" by clang-format because they contained a '-' which was interpreted as a minus sign. To fix it we add an exception to the WhitespaceSensitiveMacros list in the clang-format config. We change the macro `str` to `KHIOPS_STR` to avoid potential collisions. Also we add to CMake the KHIOPS_VERSION variable which is set to the new versioning scheme. Otherwise cmake refuses to set it as a project's version. (cherry picked from commit df6f20e)
In khiops-env, the jvm.so search is enabled only if the khiops packages is installed.
The new versioning scheme MAJOR.MINOR.PATCH{-PRE_RELEASE.PR_INCREMENT} is now handled in the Linux packages:
- in the packages names e.g. khiops_10.5.0-a1-1_amd64.deb or kni-10.5.0_a1-1.x86_64.rpm
- in the so files installed by kni e.g. libKhiopsNativeInterface.so.10.5.0-a1
(cherry picked from commit 5154cbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: wrong errno in remote fread
some minor improvments