-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conda packaging in dev #226
Conversation
.gitignore
Outdated
@@ -20,7 +20,11 @@ CMakeFiles/ | |||
# Test exceptions | |||
test/UnitTests/*/results/ | |||
test/LearningTest/*/*/*/results/ | |||
test/*/results/ | |||
test/LearningTest/*/*/*/results.ref/time.log | |||
results/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think line 23 and 25 are redundant with 21 and 22. We can choose to set only line 25 over 21 22 and 23 (to discuss)
line 24 is wrong, we have to keep time.log in results.ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just not to have a range too large how about test/**/results/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just modify the .gitignore file
37e5ba6
to
0c691c2
Compare
We recover the CI workflow from khiops-python. Now the conda packaging of the Khiops binaries (`khiops-core` package) in the khiops domain.
0c691c2
to
7e3a233
Compare
Same as #214 but for
dev