196 assertion violated in kwprobabilitytabletest #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcboulle
force-pushed
the
196-assertion-violated-in-kwprobabilitytabletest
branch
from
e032fb4 to
b19d9ce
Compare
folmos-at-orange
approved these changes
Apr 10, 2024
Comment on lines
226
to
230
| // Parametrage de l'arret pour la memoire | ||
| //MemSetAllocIndexExit(3391); | ||
|
|
There was a problem hiding this comment.
Should we keep this commented line ?
There was a problem hiding this comment.
Cela m'a été difficile de trouver l'endroit ou paramétrer cette ligne, puisque le framework GoogleTest ne semble pas avoir de main().
Je vais rajouter un commentaire.
Ameliorations dans le framework des tests unitaires: - FileCompareForTest: prise en compte des erreurs dans le cas de nombres de lignes different entre Test et Ref - TestAndCompareResults: parametrage de l'arrete de la memoire (commente) s'il y a des fuites memoire a identifier Correction des test unitaires: - KWClass::Test: nommage des variable de type TextList desormais different de celui des variable de type text - KWProbabilityTable::Test: correction des methdoes d'initialisation CreateTestAttribute (prise en compte des information des nouveaux prior) Nouveaux resultats de references pour KWData_KWClass.txt et KWData_KWClassDomain.txt
Contexte:
- les methodes de KWClass et KWClassDomain renvoie false
- si entite cree ou renomme existe (pour Insert et Rename)
- si entite detyruite n'existe pas (pour Remove).
- ce comportement a ete source de bug (fuite memoire dans KWClass::CreateClass)
- n'est jamais exploite (sauf quelques rares fois avec bOk = Insert... suivi de assert(bOk)
Amélioration
- passage de ces methode en void
- le controle se fait desormais pas un require
- pas d'impact sur le code existant (sauf quelques rare micro-corrections)
- Methodes concernees
- KWClassDomain
- InsertClass
- RemoveClass
- DeleteClass
- RenameClass
- RenameAttribute
- InsertDomain
- RemoveDomain
- DeleteDomain
- RenameDomain
- KWClass
- InsertAttribute
- InsertAttributeBefore, InsertAttributeAfter
- InsertAttributeInBlock
- RenameAttribute
Tests complets LearningTest passes avec succes
marcboulle
force-pushed
the
196-assertion-violated-in-kwprobabilitytabletest
branch
from
b19d9ce to
a98d58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction des bugs des tests unitaires
Plus au passage, simplification des méthode Insert, Rename, Remove de KWClass et KWClassDomain