Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force gcc optimization to O1 in KWDGPODiscretizer #238

Merged

Conversation

bruno-at-orange
Copy link
Contributor

@bruno-at-orange bruno-at-orange commented Apr 15, 2024

With gcc 12.2.0 (on debian 12), gcc seems too aggressive. The only way to fix a segmentation fault is to force the optimization level to O1 instead of O2.

The segmentation fault occurred while accessing the variable cell1 which is NULL. By adding the following (unnecessary) line, the segmentation fault vanishes:

if (cell1==NULL or cell2==NULL) exit(1);

With O1 optimization level, this line is not necessary to cope with this segmentation fault
close #163

@bruno-at-orange bruno-at-orange linked an issue Apr 15, 2024 that may be closed by this pull request
@bruno-at-orange bruno-at-orange force-pushed the 163-segmentation-fault-of-coclustering-on-debian-12 branch 3 times, most recently from b9c81cd to d3edbad Compare April 15, 2024 15:10
With gcc 12.2.0 (on debian 12), gcc seems too agressive. The only way to fix a segmentation fault
is to force the optimization level to O1 instead of O2.

The segmentation fault occured while accessing the variable cell1 which is NULL. By adding the
following (unnecessary) line, the segmentation fault vanishes:
if (cell1==NULL or cell2==NULL) exit(1);
@bruno-at-orange bruno-at-orange force-pushed the 163-segmentation-fault-of-coclustering-on-debian-12 branch from d3edbad to bfc01f0 Compare April 15, 2024 15:17
Copy link
Collaborator

@marcboulle marcboulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Cette correction sera à valider définitivement en relançant tous les test de LearningTest

@bruno-at-orange bruno-at-orange merged commit fdab2c1 into dev Apr 16, 2024
42 checks passed
@bruno-at-orange bruno-at-orange deleted the 163-segmentation-fault-of-coclustering-on-debian-12 branch April 16, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault of coclustering on debian 12
2 participants