Avoid using unnecessay key variables in multi-table feature construction #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcboulle
force-pushed
the
463-avoid-using-unnecessay-key-variables-in-multi-table-feature-construction
branch
2 times, most recently
from
2487446 to
f571965
Compare
popescu-v
reviewed
Dec 16, 2024
| // d'enregistrements (par CountDistinct, ici redondant avec Count). | ||
| // On interdit l'utilisation des cles du schema-multi-table pour la construction de variables. | ||
| // Les cles ne sont pas des attributs porteurs d'information. | ||
| // Pour la classe racine, les cles apparaissent une seule fois par instance, et ne peuvent pas etre informatives. |
There was a problem hiding this comment.
Shouldn't we rather mention "classe principale" ("main class" / "main table") rather than "root"?
There was a problem hiding this comment.
Corrigé
- cette PR a été fait indépendamment de la PR 462 improving uniqueness management in multi table schemas #484 qui a pris en charge le renommage systématique selon root ou main
- et ici, il s'agit bien de la classe pirncipale
popescu-v
reviewed
Dec 16, 2024
marcboulle
force-pushed
the
463-avoid-using-unnecessay-key-variables-in-multi-table-feature-construction
branch
from
f571965 to
052bcff
Compare
popescu-v
approved these changes
Dec 17, 2024
Contexte - schema en etoile, construction de variable - comme la cle d'une sous-table (du moins la sous-partie commune à la cle de la table mere) ne peut contenir d'information dejà traitee dans le dictionnaire parent, cette cle n'est pas exploitee pour la construction de variable - exemple: SpliceJunction - la variable SampleId est utilise en cle de SpliceJunction - la variable SampleId est utilisee en cle de la table secondaire SpliceJunctionDNA - on n'exploite donc pas cette variable Probleme potentiel: - si le champ cle de la table secondaire a un autre nom, cette variable secondaire peut alors etre traitee à tort comme un champ non cle distinct de la cle du dictionnaire parent, et etre exploitee pour la construction de variable - exemple: - SpliceJunction, en renommant Sample_Id en SampleId dans la table secondaire - les resultats de modelisation en generant 100 variables seraient alors differents à tort En fait, le probleme est deja traite correctement dans le code - KDMultiTableFeatureConstruction::ComputeAllClassesCompliantRules - on a uniquement enrichi le commentaire, et corrige les typos Ajout d'un jeu de test dedie LearningTest\TestKhiops\MultiTables\SchemaDifferentKeyNames
marcboulle
force-pushed
the
463-avoid-using-unnecessay-key-variables-in-multi-table-feature-construction
branch
from
052bcff to
1d4a36d
Compare
marcboulle
deleted the
463-avoid-using-unnecessay-key-variables-in-multi-table-feature-construction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Probleme potrentiel:
En fait, le probleme est deja traite correctement dans le code
Ajout d'un jeu de test dedie LearningTest\TestKhiops\MultiTables\SchemaDifferentKeyNames