Simplify repetitive copy-paste declarations of single-value Vulkan commands. #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmands. There are many MVKCommand subclasses that simply encode a single value, resulting in loads of repetitive copy-pasted code. - Add abstract template superclass MVKSingleValueCommand for these concrete command classes. - Modify MVKCmdSetBlendConstants to hold an MVKColor32 so it can subclass from MVKSingleValueCommand, and modify MVKGraphicsPipeline and MVKRenderingCommandEncoderState to use MVKColor32. - Remove trivial comments for simple concrete Vulkan command classes.
cdavis5e
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many
MVKCommandsubclasses that simply encode a single value, resulting in loads of repetitive copy-pasted code.MVKSingleValueCommandfor these concrete command classes.MVKCmdSetBlendConstantsto hold anMVKColor32so it can subclass fromMVKSingleValueCommand, and modifyMVKGraphicsPipelineandMVKRenderingCommandEncoderStateto useMVKColor32.@cdavis5e This has interactions with your PR #2142, particularly your new
MVKCmdSetDepthBoundsandMVKCmdSetDepthBoundsTestEnableclasses, which should both become subclasses ofMVKSingleValueCommand(forMVKCmdSetDepthBounds, by passing & tracking anMVKDepthBounds, similar to howMVKCmdSetBlendConstantspasses and tracks aMVKColor32).So we'll need to merge these two PRs in order. We can either merge this PR first, and you modify PR #2142, or merge #2142 first, once we've resolved the discussion there, and then I'll add
MVKCmdSetDepthBoundsandMVKCmdSetDepthBoundsTestEnableto this PR.