Consolidation and fixes for MVK_USE_METAL_PRIVATE_API functionality. #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdavis5e
approved these changes
Feb 9, 2024
- Expose MTLRenderPipelineDescriptor.sampleMaskMVK and MTLSamplerDescriptor.lodBiasMVK properties when MVK_USE_METAL_PRIVATE_API build setting is disabled. - MVKCmdSetDepthBias & MVKCmdSetDepthBounds subclass from MVKSingleValueCommand. - MVKRenderingCommandEncoderState simplify calls to set depth bias and depth bounds, and make consistent with other settings. - Refactor MVKRenderingCommandEncoderState::setContent() and setMTLContent() to remove need for intermediate value copies. - MVKPipeline remove test for depth bounds support since it's checked before GPU encoding. - MVKDepthBias member order same as in Vulkan calls. - Whats_New.md consolidate notes about MVK_USE_METAL_PRIVATE_API.
billhollings
force-pushed
the
private-api-fixes
branch
from
44b4482 to
efaae79
Compare
cdavis5e
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTLRenderPipelineDescriptor.sampleMaskMVKandMTLSamplerDescriptor.lodBiasMVKproperties whenMVK_USE_METAL_PRIVATE_APIbuild setting is disabled.MVKCmdSetDepthBias&MVKCmdSetDepthBoundssubclass fromMVKSingleValueCommand.MVKRenderingCommandEncoderStatesimplify calls to set depth bias and depth bounds, and make consistent with other settings.MVKRenderingCommandEncoderState::setContent()andsetMTLContent()to remove need for intermediate value copies.MVKPipelineremove test for depth bounds support since it's checked before GPU encoding.MVKDepthBiasmember order same as in Vulkan calls.Whats_New.mdconsolidate notes aboutMVK_USE_METAL_PRIVATE_API.