Fix visionOS build #2161
Merged
Fix visionOS build #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
billhollings
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Thanks for submitting this! VisionOS is poorly supported on MoltenVK, and this will really help.
I've requested some changes.
visionOS is also not yet enabled by default, not sure if we want to require Xcode 15 just yet and couldn't find a way of doing conditional dependencies in Xcode projects or Makefiles.
We can't force Xcode 15 yet, so we'll probably have to leave it out of an all build for now. However, it would be good to add an Xcode 15 build on VisionOS to CI.yml. If you aren't familiar with this, I can add that later.
mkrus
force-pushed
the
fix/visionOS_build
branch
from
8bdd6d7 to
13bbffb
Compare
This adds a few macros to test which platform is currently being built. Addresses some compile warnings such as missing return values.
mkrus
force-pushed
the
fix/visionOS_build
branch
from
13bbffb to
9082ca8
Compare
billhollings
approved these changes
Mar 6, 2024
Restore original formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few macros to test which platform is currently being built. Addresses some compile warnings such as missing return values. Still a fair amount of deprecation warnings to handle.
Have not actually tested the resulting binary yet.
visionOS is also not yet enabled by default, not sure if we want to require Xcode 15 just yet and couldn't find a way of doing conditional dependencies in Xcode projects or Makefiles.
Fix #2160.