Enable use of native texture atomics. #2164
Conversation
js6i
force-pushed
the
native-atomics
branch
2 times, most recently
from
6b79e9d to
67bed4f
Compare
This commit conditionally skips the emulated image atomics paths if native texture atomics are available and a configuration option is set. Apart from unlocking some potential performance benefits from not having to force some textures to be linear, it also makes texture atomics work with argument buffers.
| _isLinearForAtomics = (_arrayLayers == 1 && _mipLevels == 1 && getImageType() == VK_IMAGE_TYPE_2D && mvkIsAnyFlagEnabled(getCombinedUsage(), VK_IMAGE_USAGE_STORAGE_BIT) && | ||
| ((_vkFormat == VK_FORMAT_R32_UINT || _vkFormat == VK_FORMAT_R32_SINT) || | ||
| (_hasMutableFormat && pixFmts->getViewClass(_vkFormat) == MVKMTLViewClass::Color32 && | ||
| (getIsValidViewFormat(VK_FORMAT_R32_UINT) || getIsValidViewFormat(VK_FORMAT_R32_SINT))))); | ||
| _shouldSupportAtomics = mvkIsAnyFlagEnabled(getCombinedUsage(), VK_IMAGE_USAGE_STORAGE_BIT) && _mipLevels == 1 && | ||
| ((_vkFormat == VK_FORMAT_R32_UINT || _vkFormat == VK_FORMAT_R32_SINT) || | ||
| (_hasMutableFormat && pixFmts->getViewClass(_vkFormat) == MVKMTLViewClass::Color32 && (getIsValidViewFormat(VK_FORMAT_R32_UINT) || getIsValidViewFormat(VK_FORMAT_R32_SINT)))); | ||
|
|
||
| if (_shouldSupportAtomics && !getPhysicalDevice()->useNativeTextureAtomics()) | ||
| _isLinearForAtomics = _arrayLayers == 1 && getImageType() == VK_IMAGE_TYPE_2D; |
There was a problem hiding this comment.
Something about this change here appears to have caused #2168.
|
Apart from #2168, I found a second issue when testing another patch - the validation layer complains about Perhaps, for image views, we could force the primary pixel format of the texture to be an integer, and then make views on that.. |
Can you open an issue tracker for this second valuation issue? |
This commit conditionally skips the emulated image atomics paths if native texture atomics are available and a configuration option is set.
Apart from unlocking some potential performance benefits from not having to force some textures to be linear, it also makes texture atomics work with argument buffers.