fix memory management issue in MVKSwapchain

[NekoAsakura]

#2399
Fix memory management issue in MVKSwapchain

[CLAassistant]

All committers have signed the CLA.

[gnattu]

I'm afraid this change alone is not enough to fix the problem described in #2399. It appears that CAEDRMetadata is also a managed objc object which the autorelease pool might trying to release and still cause the double free crash. Chromium does not do explicit release on this object and I think we should do the same.

This is already reproducible by using mpv with gpu-next and target-colorspace-hint=yes, play an HDR file, enter the full screen then quit the full screen, then close the player, you would see a segfault. This segfault disappears after removing the explicit release of CAEDRMetadata

[m154k1]

This is already reproducible by using mpv with gpu-next and target-colorspace-hint=yes, play an HDR file, enter the full screen then quit the full screen, then close the player, you would see a segfault.

I can confirm this.

This segfault disappears after removing the explicit release of CAEDRMetadata

@gnattu could you please upload the patch?

[gnattu]

To test this for mpv it is quite trivial, you just remove this line:

MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKSwapchain.mm

Line 367 in 138415d

[caMetadata release];

But since the autorelease pool might not exist everywhere, I think the more proper way of doing this is to wrap the usage of CAEDRMetadata in @autoreleasepool {...} block

[billhollings]

I think the more proper way of doing this is to wrap the usage of CAEDRMetadata in @autoreleasepool {...} block

Fixed in #2436.