Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertise VK_KHR_shader_terminate_invocation. #2424

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Advertise VK_KHR_shader_terminate_invocation. #2424

merged 2 commits into from
Feb 6, 2025
+14 −5

Conversation

squidbus
Copy link
Contributor

OpTerminateInvocation is already handled in SPIRV-Cross identically to OpKill. Advertise support for the extension.

billhollings
billhollings requested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this!

Please see notes below about also updating MVKDeviceFeatureStructs.def.

MoltenVK/MoltenVK/GPUObjects/MVKDevice.mm Outdated Show resolved Hide resolved
billhollings
billhollings approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM now.

@billhollings billhollings merged commit 8a3131e into KhronosGroup:main Feb 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhollings billhollings billhollings approved these changes

@cdavis5e cdavis5e cdavis5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squidbus @billhollings @cdavis5e