Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not saving shouldFixupClipSpace when serializing a pipeline. #2432

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix not saving shouldFixupClipSpace when serializing a pipeline. #2432

merged 1 commit into from
Jan 30, 2025

Conversation

squidbus
Copy link
Contributor

Small fix pointed out in #2430 (comment); need to add shouldFixupClipSpace option to pipeline serialization.

@squidbus squidbus mentioned this pull request Jan 29, 2025
Merged
cdavis5e
cdavis5e approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me smacks forehead

This is as much my fault as it is yours, since I should've caught this before recklessly approving your change.

@cdavis5e cdavis5e merged commit 0c09000 into KhronosGroup:main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavis5e cdavis5e cdavis5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squidbus @cdavis5e