vulkan: Remove redundant negative testing

- negative testing for semaphore functions is accomplished in semaphore tests, as well as create image in the api test
KhronosGroup · Sep 10, 2024 · 73e757a · 73e757a
1 parent c32a767
commit 73e757a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 134 deletions.
diff --git a/test_conformance/vulkan/test_vulkan_api_consistency.cpp b/test_conformance/vulkan/test_vulkan_api_consistency.cpp
@@ -323,27 +323,6 @@ int test_consistency_external_image(cl_device_id deviceID, cl_context _context,
     test_error(errNum, "Unable to create Image with Properties");
     image.reset();
 
-    // Passing image_format as NULL
-    image = clCreateImageWithProperties(context, extMemProperties.data(),
-                                        CL_MEM_READ_WRITE, NULL, &image_desc,
-                                        NULL, &errNum);
-    test_failure_error(errNum, CL_INVALID_IMAGE_FORMAT_DESCRIPTOR,
-                       "Image creation must fail with "
-                       "CL_INVALID_IMAGE_FORMAT_DESCRIPTOR"
-                       "when image desc passed as NULL");
-
-    image.reset();
-
-    // Passing image_desc as NULL
-    image = clCreateImageWithProperties(context, extMemProperties.data(),
-                                        CL_MEM_READ_WRITE, &img_format, NULL,
-                                        NULL, &errNum);
-    test_failure_error(errNum, CL_INVALID_IMAGE_DESCRIPTOR,
-                       "Image creation must fail with "
-                       "CL_INVALID_IMAGE_DESCRIPTOR "
-                       "when image desc passed as NULL");
-    image.reset();
-
     return TEST_PASS;
 }
 
@@ -479,31 +458,6 @@ int test_consistency_external_semaphore(cl_device_id deviceID,
     sema_props1.push_back(0);
     sema_props2.push_back(0);
 
-    // Pass NULL properties
-    cl_semaphore_khr cl_ext_semaphore =
-        clCreateSemaphoreWithPropertiesKHRptr(context, NULL, &errNum);
-    test_failure_error(errNum, CL_INVALID_VALUE,
-                       "Semaphore creation must fail with CL_INVALID_VALUE "
-                       " when properties are passed as NULL");
-
-
-    // Pass invalid semaphore object to wait
-    errNum =
-        clEnqueueWaitSemaphoresKHRptr(cmd_queue, 1, NULL, NULL, 0, NULL, NULL);
-    test_failure_error(errNum, CL_INVALID_VALUE,
-                       "clEnqueueWaitSemaphoresKHR fails with CL_INVALID_VALUE "
-                       "when invalid semaphore object is passed");
-
-
-    // Pass invalid semaphore object to signal
-    errNum = clEnqueueSignalSemaphoresKHRptr(cmd_queue, 1, NULL, NULL, 0, NULL,
-                                             NULL);
-    test_failure_error(
-        errNum, CL_INVALID_VALUE,
-        "clEnqueueSignalSemaphoresKHR fails with CL_INVALID_VALUE"
-        "when invalid semaphore object is passed");
-
-
     // Create two semaphore objects
     clVk2Clsemaphore = clCreateSemaphoreWithPropertiesKHRptr(
         context, sema_props1.data(), &errNum);
@@ -515,12 +469,6 @@ int test_consistency_external_semaphore(cl_device_id deviceID,
     test_error(errNum,
                "Unable to create semaphore with valid semaphore properties");
 
-    // Pass invalid object to release call
-    errNum = clReleaseSemaphoreKHRptr(NULL);
-    test_failure_error(errNum, CL_INVALID_VALUE,
-                       "clReleaseSemaphoreKHRptr fails with "
-                       "CL_INVALID_VALUE when NULL semaphore object is passed");
-
     // Release both semaphore objects
     errNum = clReleaseSemaphoreKHRptr(clVk2Clsemaphore);
     test_error(errNum, "clReleaseSemaphoreKHRptr failed");

diff --git a/test_conformance/vulkan/test_vulkan_api_consistency_for_1dimages.cpp b/test_conformance/vulkan/test_vulkan_api_consistency_for_1dimages.cpp
@@ -158,47 +158,6 @@ int test_consistency_external_for_1dimage(cl_device_id deviceID,
     test_error(errNum, "Unable to create Image with Properties");
     image.reset();
 
-    // Passing properties, image_desc and image_format all as NULL
-    image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE, NULL,
-                                        NULL, NULL, &errNum);
-    test_failure_error(
-        errNum, CL_INVALID_IMAGE_DESCRIPTOR,
-        "Image creation must fail with CL_INVALID_IMAGE_DESCRIPTOR "
-        "when all are passed as NULL");
-
-    image.reset();
-
-    // Passing NULL properties and a valid image_format and image_desc
-    image =
-        clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE,
-                                    &img_format, &image_desc, NULL, &errNum);
-    test_error(errNum,
-               "Unable to create image with NULL properties "
-               "with valid image format and image desc");
-
-    image.reset();
-
-    // Passing image_format as NULL
-    image = clCreateImageWithProperties(context, extMemProperties.data(),
-                                        CL_MEM_READ_WRITE, NULL, &image_desc,
-                                        NULL, &errNum);
-    test_failure_error(errNum, CL_INVALID_IMAGE_FORMAT_DESCRIPTOR,
-                       "Image creation must fail with "
-                       "CL_INVALID_IMAGE_FORMAT_DESCRIPTOR"
-                       "when image desc passed as NULL");
-
-    image.reset();
-
-    // Passing image_desc as NULL
-    image = clCreateImageWithProperties(context, extMemProperties.data(),
-                                        CL_MEM_READ_WRITE, &img_format, NULL,
-                                        NULL, &errNum);
-    test_failure_error(errNum, CL_INVALID_IMAGE_DESCRIPTOR,
-                       "Image creation must fail with "
-                       "CL_INVALID_IMAGE_DESCRIPTOR "
-                       "when image desc passed as NULL");
-    image.reset();
-
     if (cmd_queue) clReleaseCommandQueue(cmd_queue);
     if (context) clReleaseContext(context);
 

diff --git a/test_conformance/vulkan/test_vulkan_api_consistency_for_3dimages.cpp b/test_conformance/vulkan/test_vulkan_api_consistency_for_3dimages.cpp
@@ -162,47 +162,6 @@ int test_consistency_external_for_3dimage(cl_device_id deviceID,
     test_error(errNum, "Unable to create Image with Properties");
     image.reset();
 
-    // Passing properties, image_desc and image_format all as NULL
-    image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE, NULL,
-                                        NULL, NULL, &errNum);
-    test_failure_error(
-        errNum, CL_INVALID_IMAGE_DESCRIPTOR,
-        "Image creation must fail with CL_INVALID_IMAGE_DESCRIPTOR "
-        "when all are passed as NULL");
-
-    image.reset();
-
-    // Passing NULL properties and a valid image_format and image_desc
-    image =
-        clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE,
-                                    &img_format, &image_desc, NULL, &errNum);
-    test_error(errNum,
-               "Unable to create image with NULL properties "
-               "with valid image format and image desc");
-
-    image.reset();
-
-    // Passing image_format as NULL
-    image = clCreateImageWithProperties(context, extMemProperties.data(),
-                                        CL_MEM_READ_WRITE, NULL, &image_desc,
-                                        NULL, &errNum);
-    test_failure_error(errNum, CL_INVALID_IMAGE_FORMAT_DESCRIPTOR,
-                       "Image creation must fail with "
-                       "CL_INVALID_IMAGE_FORMAT_DESCRIPTOR"
-                       "when image desc passed as NULL");
-
-    image.reset();
-
-    // Passing image_desc as NULL
-    image = clCreateImageWithProperties(context, extMemProperties.data(),
-                                        CL_MEM_READ_WRITE, &img_format, NULL,
-                                        NULL, &errNum);
-    test_failure_error(errNum, CL_INVALID_IMAGE_DESCRIPTOR,
-                       "Image creation must fail with "
-                       "CL_INVALID_IMAGE_DESCRIPTOR "
-                       "when image desc passed as NULL");
-    image.reset();
-
     if (cmd_queue) clReleaseCommandQueue(cmd_queue);
     if (context) clReleaseContext(context);