Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XML] Performance query group and class definitions #576

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

SunSerega
Copy link
Contributor

No description provided.

@pdaniell-nv
Copy link
Contributor

@Perksey any objections to this change from you?

Copy link
Contributor

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thanks for the ping. Seems simple enough, no objections :)

@NogginBops
Copy link
Contributor

It might be good to do something like we did with kinds where we keep a list of the ones that are present in the specification. Otherwise I have no problem with this.

@SunSerega
Copy link
Contributor Author

Do you mean something like this? (I thought spec is the .pdf file)

<classes>
    <class name="..." description="...">
</classes>

When I was suggesting this for kinds (you quoted it here), I noted the difference with classes:

Unlike classes, which are solely defined by their uses and being a namespace, [...]

So the human-readable description would probably be redundant for classes...
But maybe some other info, like the extension, in which the class is defined, would be useful...
What do you think could be better described in this way?

@NogginBops
Copy link
Contributor

I guess I mostly wanted some way to know about what a "perf query" is as it's an extension concept and not part of the core OpenGL specification. But maybe gl.xml isn't the right place for that.

@pdaniell-nv
Copy link
Contributor

This is approved to merge if @NogginBops doesn't object.

@SunSerega
Copy link
Contributor Author

I guess I mostly wanted some way to know about what a "perf query" is

Yeah, that's understandable...
But I think starting from that is backward. For the use cases I see - I expect people to first understand a function, which uses a class. Then, while looking at another function - notice the handle of the same class is needed, so they must be connected. And that alone would already give the consumer all the info there is about the said class.

@Perksey
Copy link
Contributor

Perksey commented May 25, 2023

I think a schema change is out of scope of this PR specifically.

@NogginBops
Copy link
Contributor

Sorry for responding so late! I'm absolutely fine with merging this PR.

@pdaniell-nv
Copy link
Contributor

@oddhack this is approved to merge.

@oddhack oddhack merged commit efb5911 into KhronosGroup:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants