-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XML] Performance query group and class definitions #576
Conversation
@Perksey any objections to this change from you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, thanks for the ping. Seems simple enough, no objections :)
It might be good to do something like we did with |
Do you mean something like this? (I thought spec is the .pdf file)
When I was suggesting this for kinds (you quoted it here), I noted the difference with classes:
So the human-readable description would probably be redundant for classes... |
I guess I mostly wanted some way to know about what a "perf query" is as it's an extension concept and not part of the core OpenGL specification. But maybe gl.xml isn't the right place for that. |
This is approved to merge if @NogginBops doesn't object. |
Yeah, that's understandable... |
I think a schema change is out of scope of this PR specifically. |
Sorry for responding so late! I'm absolutely fine with merging this PR. |
@oddhack this is approved to merge. |
No description provided.