Install XrApiLayer_conformance_test_layer.json
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is missing from at least the Openxr-cts-x64 bundle, and appears to not be installed by CMake Taken the same approach as https://github.com/KhronosGroup/OpenXR-CTS/blob/devel/src/conformance/conformance_layer/CMakeLists.txt Without this, `validApiLayer` fails on all runtimes when using a prebuild CTS bundle.
|
|
|
Oh good catch! Adding that layer-related test has definitely caused a few glitches on the CTS side of things, thanks for adding this. Can you add a changelog fragment in |
rpavlik
approved these changes
Nov 26, 2024
rpavlik
approved these changes
Nov 27, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is missing from at least the Openxr-cts-x64 bundle, and appears to not be installed by CMake
Taken the same approach as https://github.com/KhronosGroup/OpenXR-CTS/blob/devel/src/conformance/conformance_layer/CMakeLists.txt
Without this,
validApiLayerfails on all runtimes when using a prebuild CTS bundle.