Do not use C99 VLA in C++ code #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for KhronosGroup#848
bader
reviewed
Jan 31, 2025
bader
reviewed
Jan 31, 2025
bader
approved these changes
Jan 31, 2025
keryell
commented
Feb 1, 2025
| { | ||
| sycl::buffer<bool, 1> res_buf(result, sycl::range(code_count)); | ||
| sycl::buffer<char, 1> res_buf(result); |
There was a problem hiding this comment.
@bader Oops! Good catch.
It was CI, not me. ;)
There was a problem hiding this comment.
I was puzzled by AdaptiveCpp passing.
There was a problem hiding this comment.
AdaptiveCpp doesn't not compile this test case: https://github.com/keryell/SYCL-CTS/blob/9c269373f6ce38efd35f7d2db6e2675c1107f83c/tests/sub_group/sub_group_semantics.cpp#L118-L120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #848.