Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catching the right type of exception #844

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Catching the right type of exception #844

merged 2 commits into from
Jan 11, 2024

Conversation

ChengChen002
Copy link
Contributor

It throws sycl::exception instead of sycl::feature_not_supported when failed to test kernel args with samplers.

@ChengChen002 ChengChen002 requested a review from a team as a code owner January 4, 2024 08:38
@bader bader changed the title [SYCL-CTS] Catching the right type of exception Catching the right type of exception Jan 5, 2024
@bader bader added the help wanted Extra attention is needed label Jan 9, 2024
keryell
keryell approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bader bader merged commit 2e45cea into KhronosGroup:SYCL-2020 Jan 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengChen002 @keryell @bader