Fix kernel_bundle tests for multi-device systems #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the kernel_bundle tests make faulty assumptions about the set of devices used in the kernel bundles. This commit fixes these assumptions. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
keryell
reviewed
Mar 14, 2024
tests/common/common.h
Outdated
| auto device_order_f = [](const sycl::device& d1, | ||
| const sycl::device& d2) -> bool { | ||
| std::hash<sycl::device> h{}; | ||
| return h(d1) < h(d2); |
There was a problem hiding this comment.
I thought we added that in the spec.
But not yet: https://gitlab.khronos.org/sycl/Specification/-/issues/586
There was a problem hiding this comment.
But is this a working order?
What happens when we have 2 different devices with the same hash value?
I am afraid that while we have not solved gitlab.khronos.org/sycl/Specification/-/issues/586 we are stuck with a quadratic algorithm. :-(
There was a problem hiding this comment.
Sadly, that's a good point. I've changed it to the simple, but valid, implementation.
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
keryell
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
@steffenlarsen We should make a common proposal for the next F2F on "Make SYCL types with reference semantics totally ordered" since you have enough suffered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the kernel_bundle tests make faulty assumptions about the set of devices used in the kernel bundles. This commit fixes these assumptions.