Remove std_classes test
#883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test seems to be 1.2.1 legacy, which doesn't make sense in SYCL 2020 testing: - the test does not check anything at runtime - the only compile-time "check" which is performed is successful compilation of the test source itself and there are no static assertions - test source code contains nothing SYCL-specific and only uses standard C++ functionality The test used to check type aliases like `cl::sycl::string_class`, but it lost its purpose in e08cb45 when it was updated to match SYCL 2020 interface that directly uses standard C++ containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test seems to be 1.2.1 legacy, which doesn't make sense in SYCL 2020 testing:
The test used to check type aliases like
cl::sycl::string_class, but it lost its purpose in e08cb45 when it was updated to match SYCL 2020 interface that directly uses standard C++ containers.