-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test plan for sycl_ext_oneapi_enqueue_functions
extension
#898
Add test plan for sycl_ext_oneapi_enqueue_functions
extension
#898
Conversation
Signed-off-by: Michael Aziz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to also have static_assert
on the return type of all of these functions, but other than that I think this looks reasonable.
Implement the tests from KhronosGroup#898. Signed-off-by: Michael Aziz <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
@gmlueck, ping. |
I trust @steffenlarsen's review. Is there a specific question you would like me to answer? |
You are the code owner of test plans for extensions, so formally either you or SYCL implementation representatives (i.e. @KhronosGroup/sycl-cts-reviewers team) have to approve test plans. |
Yes, I agree. |
@gmlueck It could be interesting if these functions were able to be found via ADL to avoid the namespace, for example if the extension header is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good.
In order to do this, I think we would need to define these functions in the |
No description provided.