Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to execute tests on already built binaries #918

Conversation

dm-vodopyanov
Copy link
Contributor

This patch adds new option --run-only to run_conformance_tests.py to be able to execute tests on already built binaries.

This patch adds new option `--run-only` to `run_conformance_tests.py` to
be able to execute tests on already built binaries.
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner July 25, 2024 13:46
run_conformance_tests.py Outdated Show resolved Hide resolved
@bader bader requested a review from a team July 31, 2024 21:26
@dm-vodopyanov
Copy link
Contributor Author

Failure in SYCL CTS CI / compile-cts (dpcpp, 20a088e1231c4ac85fd74c0de79c563977d2f38c) (pull_request) seems unrelated, a problem in CI:

/usr/bin/ld: final link failed: No space left on device
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

@dm-vodopyanov
Copy link
Contributor Author

@bader can you please merge the PR as ead430a has only non-functional changes? The previous commit passes in pre-commit.

@bader
Copy link
Contributor

bader commented Aug 6, 2024

@bader can you please merge the PR as ead430a has only non-functional changes? The previous commit passes in pre-commit.

@dm-vodopyanov, no. It's not ready for merge.

Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

run_conformance_tests.py Outdated Show resolved Hide resolved
@bader
Copy link
Contributor

bader commented Aug 7, 2024

Failure in SYCL CTS CI / compile-cts (dpcpp, 20a088e1231c4ac85fd74c0de79c563977d2f38c) (pull_request) seems unrelated, a problem in CI:

/usr/bin/ld: final link failed: No space left on device
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

This issue appears twice in this PR and that worries me. @steffenlarsen, do you think recent changes might cause this?

@steffenlarsen
Copy link
Contributor

This issue appears twice in this PR and that worries me. @steffenlarsen, do you think recent changes might cause this?

It definitely doesn't look related to the changes proposed here. I suppose any addition of tests increases the memory consumption of test_all. I am on the cusp of saying we should just drop test_all or not build it in CI. It is somewhat redundant, though slightly different, as it is an executable combining all the categories. Personally, I think it should build test_conformance instead, which is test_all without the mastodon of an executable that is test_all.

@bader
Copy link
Contributor

bader commented Aug 7, 2024

This issue appears twice in this PR and that worries me. @steffenlarsen, do you think recent changes might cause this?

It definitely doesn't look related to the changes proposed here. I suppose any addition of tests increases the memory consumption of test_all. I am on the cusp of saying we should just drop test_all or not build it in CI. It is somewhat redundant, though slightly different, as it is an executable combining all the categories. Personally, I think it should build test_conformance instead, which is test_all without the mastodon of an executable that is test_all.

Okay. I'm merging this PR and will watch CI results. If this issue impacts CI results, we will need to figure something out.

@bader bader merged commit b15d028 into KhronosGroup:SYCL-2020 Aug 7, 2024
6 of 8 checks passed
@bader
Copy link
Contributor

bader commented Aug 7, 2024

Failure in SYCL CTS CI / compile-cts (dpcpp, 20a088e1231c4ac85fd74c0de79c563977d2f38c) (pull_request) seems unrelated, a problem in CI:

/usr/bin/ld: final link failed: No space left on device
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

@steffenlarsen, I think we need address this issue ASAP. Now we have four consecutive failures due to this issue: 3 runs before the merge and one run after the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants