Skip to content

Commit

Permalink
Undeprecate legacy multi_ptr
Browse files Browse the repository at this point in the history
The legacy decoration for multi_ptr has been made the default template
argument of the decoration in multi_ptr to bridge the gap between
SYCL 1.2.1 and SYCL 2020 multi_ptr interfaces. However, the legacy
decoration and the specialization of multi_ptr with the decoration is
deprecated with SYCL 2020. This is confusing to users as they may easily
run into deprecation warnings simply due to not specifying the
decoration. This commit proposes that we remove the deprecation of
legacy in SYCL 2020.

Signed-off-by: Larsen, Steffen <[email protected]>
  • Loading branch information
steffenlarsen committed Aug 16, 2024
1 parent c1bc6a1 commit b393ab6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion adoc/chapters/programming_interface.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -9138,7 +9138,6 @@ For interoperability with the <<backend>>, users should rely on types exposed by
the decorated version.
If the value of [code]#access::decorated# is [code]#access::decorated::legacy#,
the 1.2.1 interface is exposed.
This interface is deprecated.

The template traits [code]#remove_decoration# and type alias
[code]#remove_decoration_t# retrieve the non-decorated pointer or reference from
Expand Down
2 changes: 1 addition & 1 deletion adoc/headers/multipointer.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ enum class address_space : /* unspecified */ {
enum class decorated : /* unspecified */ {
no,
yes,
legacy // Deprecated in SYCL 2020
legacy
};

} // namespace access
Expand Down
2 changes: 0 additions & 2 deletions adoc/headers/multipointerlegacy.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
namespace sycl {

// Legacy interface, inherited from 1.2.1.
// Deprecated.
template <typename ElementType, access::address_space Space>
class [[deprecated]] multi_ptr<ElementType, Space, access::decorated::legacy> {
public:
Expand Down Expand Up @@ -162,7 +161,6 @@ class [[deprecated]] multi_ptr<ElementType, Space, access::decorated::legacy> {
};

// Legacy interface, inherited from 1.2.1.
// Deprecated.
// Specialization of multi_ptr for void and const void
// VoidType can be either void or const void
template <access::address_space Space>
Expand Down

0 comments on commit b393ab6

Please sign in to comment.